This repository has been archived by the owner on May 18, 2023. It is now read-only.
Address time zone issues for run duration calculations #1012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using ZonedDateTime to build a date-time from the RCDB run start time and remove the dependence on the time zone that was making the FCup conversion from counts to nC dependent on the local time of the machine where the code is running.
Since the RCDB Java API doesn't provide a date but only the local time, the assumption that remains is that the run start time is within a day from the current time. However, using ZonedDateTime.minusDays method ensures the start time date is set correctly al in case of transition from or to day-light saving.
Tests on the last file from run 6419 that was recorded across a transition from EST to EDT show also the 1h time change is handled correctly in the calculation of the scaler integration time:
(printouts from two FCup scaler readouts