Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: perform QA for RG-B Pass 2 #258

Merged
merged 9 commits into from
Feb 3, 2025
Merged

feat: perform QA for RG-B Pass 2 #258

merged 9 commits into from
Feb 3, 2025

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Dec 23, 2024

  • switch cutdef files from JSON to YAML, so we can add comments
  • add the ability to filter the data that are used to calculate the IQR
    • now requiring N/F > 0, which causes a very slight narrowing of the QA cuts for most epochs
      • this is necessary for RG-D, where 2/3 of their N/F points are 0 (three QA bins per run, where the first and last have ChargeUnknown)
    • tighter N/F limits may be defined using the cutdef files, for epochs with a large number of outliers; this was needed for some RG-B epochs
  • filter benign log message VariableMetricBuilder: no improvement

@c-dilks c-dilks mentioned this pull request Jan 29, 2025
@c-dilks c-dilks changed the title feat: QADB for RG-B feat: perform QA for RG-B Pass 2 Jan 29, 2025
@c-dilks c-dilks marked this pull request as ready for review January 29, 2025 20:27
@c-dilks c-dilks merged commit a8a578c into main Feb 3, 2025
12 checks passed
@c-dilks c-dilks deleted the rgb_pass2 branch February 3, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant