fix: get rid of DRY-violating hard-coded energies #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-dilks
force-pushed
the
rgc-sp23-readiness
branch
from
9fdf1c2 to
a70614c
Compare
All existing hard-coded beam energy overrides from both `run-monitoring.sh` and `monitorRead.groovy` were cross-checked with RCDB; only RG-F has beam energies which deviate from RCDB. - Move all hard-coded RG-F beam energy overrides to `run-monitoring.sh` to resolve the DRY violation, and print a warning when they are used - Remove all other hard-coded overrides and rely on RCDB
c-dilks
force-pushed
the
rgc-sp23-readiness
branch
from
578988e to
460f825
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All existing hard-coded beam energy overrides from both
run-monitoring.shandmonitorRead.groovywere cross-checked with RCDB; only RG-F has beam energies which deviate from RCDB.run-monitoring.shto resolve the DRY violation, and print a warning when they are usedCloses #60 and supersedes #61 (README.md from #61 was also cross checked here)