Fix streak length metric reporting (flyteorg#5172)

* Don't use `defer` for streak length reporting Signed-off-by: Thomas Newton <[email protected]> * Make it work with defer Signed-off-by: Thomas Newton <[email protected]> * Fix lint Signed-off-by: Thomas Newton <[email protected]> --------- Signed-off-by: Thomas Newton <[email protected]>
Jeinhaus · Apr 8, 2024 · 7e9a6d5 · 7e9a6d5
1 parent 3377dc7
commit 7e9a6d5
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/flytepropeller/pkg/controller/handler.go b/flytepropeller/pkg/controller/handler.go
@@ -230,7 +230,7 @@ func (p *Propeller) Handle(ctx context.Context, namespace, name string) error {
 	}
 
 	streak := 0
-	defer p.metrics.StreakLength.Add(ctx, float64(streak))
+	defer func() { p.metrics.StreakLength.Add(ctx, float64(streak)) }()
 
 	maxLength := p.cfg.MaxStreakLength
 	if maxLength <= 0 {