Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes for incsearch highlighting and caret/scroll position for undo #1010

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Minor fixes for incsearch highlighting and caret/scroll position for undo #1010

merged 3 commits into from
Oct 21, 2024

Conversation

citizenmatt
Copy link
Member

This PR fixes a couple of small bugs:

  1. Highlighting for 'incsearch' now only applies to editors in the current project, rather than all open projects - VIM-3682
  2. Fixes an issues where undo/redo does not move the caret when used in an editor with a preview, such as Markdown files, or all source files in Android Studio (which includes a preview based on the code). IdeaVim will also ensure that 'scrolloff' is applied after undo/redo - VIM-3671

@citizenmatt
Only perform incsearch in current project
e7a0fe1 
Fixes VIM-3682
@citizenmatt
Invoke undo/redo on correct editor
755cd74 
Fixes VIM-3671
@citizenmatt
Scroll caret into view after undo/redo
af67b05 
This is to ensure that 'scrolloff' is applied. Relates to VIM-3671
@AlexPl292
Copy link
Member

Merged, thank you!

@AlexPl292 AlexPl292 merged commit 879d191 into JetBrains:master Oct 21, 2024
4 checks passed
@citizenmatt citizenmatt deleted the bugfix/misc branch October 21, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@citizenmatt @AlexPl292