Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing maps #1034

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Conversation

citizenmatt
Copy link
Member

  • Adds a map for <C-PageUp/Down> and i_<C-PageUp/PageDown> to switch tabs - VIM-2044
  • Adds a map for <S-Enter> to scroll page forward - VIM-2752
  • Removes some old extended handling of special keys that was required when keys for actions were registered via a comma separated string in an XML attribute. Removes recognising « and » and also <Comma>

This was needed when action keys were registered in a comma separated list in a single XML attribute string. Additional encoding was needed for angle brackets and commas. Registration has changed, and this is no longer needed
@AlexPl292 AlexPl292 self-requested a review November 13, 2024 15:52
@AlexPl292 AlexPl292 merged commit 18d6f79 into JetBrains:master Nov 13, 2024
4 checks passed
@AlexPl292
Copy link
Member

Thank you!

@citizenmatt citizenmatt deleted the feature/missing-mappings branch November 13, 2024 15:53
@rickgladwin
Copy link

Is there a way to add changes like this as a note that will appear in the Overview tab or What's New tab in the Plugins listing in JetBrains IDEs?

This represents a breaking change for any of us that use the default behaviour for the IDE when using IdeaVim (Shift+Enter starts a new line), but the version number wasn't increased to a major version. I checked the changelog under the "What's New" tab, and this change isn't mentioned directly there either, since the change item was a feature request and not a fix.

@rickgladwin
Copy link

For anyone who winds up here while trying to figure out why the behaviour changed, this remapping in .ideavimrc will restore the default behaviour:

" map Shift+Enter to 'Start New Line' in normal mode
nmap <S-Enter> o<ESC>
" map Shift+Enter to 'Start New Line' in insert mode
imap <S-Enter> <ESC>o

(That said, I appreciate the hard work that goes into an open source project like this. It's a great resource and contributions are important and valuable)

@citizenmatt
Copy link
Member Author

Release notes aren't currently tracked automatically, but you can see what YouTrack tickets have been fixed in a release with a query such as: https://youtrack.jetbrains.com/issues?q=project:VIM%20Fix%20versions:%202.17.0. There are also sometimes changes that don't have YouTrack tickets, and those are in PRs like this one.

Apologies for breaking your muscle memory with this, but it should always have been a Vim shortcut, rather than an IDE one, and thanks for posting a workaround to restore the previous behaviour. You could probably also work around this issue by using sethandler <S-Enter> a:IDE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants