Switch from React to Compose #134
Conversation
|
@Schahen @Skolotsky could you please review too (if you have time)? |
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
=========================================
Coverage 25.19% 25.19%
Complexity 63 63
=========================================
Files 132 132
Lines 3890 3893 +3
Branches 407 407
=========================================
+ Hits 980 981 +1
- Misses 2889 2891 +2
Partials 21 21
Continue to review full report at Codecov.
|
...ctor-client-web/src/main/kotlin/org/jetbrains/projector/client/web/ui/ReconnectionMessage.kt
Outdated
Show resolved
Hide resolved
...ctor-client-web/src/main/kotlin/org/jetbrains/projector/client/web/ui/ReconnectionMessage.kt
Outdated
Show resolved
Hide resolved
projector-client-web/src/main/kotlin/org/jetbrains/projector/client/web/ui/LoadingIndicator.kt
Outdated
Show resolved
Hide resolved
projector-client-web/src/main/kotlin/org/jetbrains/projector/client/web/ui/LoadingIndicator.kt
Outdated
Show resolved
Hide resolved
projector-client-web/src/main/kotlin/org/jetbrains/projector/client/web/ui/LoadingIndicator.kt
Outdated
Show resolved
Hide resolved
projector-client-web/src/main/kotlin/org/jetbrains/projector/client/web/ui/LoadingIndicator.kt
Outdated
Show resolved
Hide resolved
projector-client-web/src/main/kotlin/org/jetbrains/projector/client/web/ui/LoadingIndicator.kt
Outdated
Show resolved
Hide resolved
| top(3.px) | ||
| left(37.px) | ||
| width(6.px) | ||
| height(18.px) |
There was a problem hiding this comment.
How these values are calculated? Or do they come from removed radium / react-loading-indicator ?
There was a problem hiding this comment.
No, radium / react-loading-indicator are removed for good. Everything is taken from https://loading.io/css/ (CC0 license) now, just the first link after searching something like "css create loading indicator". Let me restore comment about that.
Actually, I haven't made any research how this thing works. Thank you for pushing me to understand it and finding the stuff that can be rewritten as constants.
I guess I should have spend more time on understanding this copy-pasted sample. Since switching to Compose isn't a high priority task, will do that a bit later. And will request your review afterwards.
Co-Authored-By: Art Pinch <[email protected]>
Here React is removed and the components are rewritten in Compose