Rd-gen docs #481
Open
Rd-gen docs #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iliya-usov
reviewed
Jul 17, 2024
| - signals (sinks / signal sources): "fire and forget" | ||
| - calls, callbacks: it's possible to return a result | ||
|
|
||
| The protocol allows use for persistent models that have mutable members in memory, as well as in a RPC-like way without any persistence via signals and calls. |
There was a problem hiding this comment.
Maybe it would be better to use statful instead of persistent? Because persistent is associated with immutable collections or permanently stored on disk.
| 3. `interfacedef`: declares an interface that may be implemented by other types. Example: | ||
| ```kotlin | ||
| val Interface = interfacedef { | ||
| call("foo", PredefinedType.void, PredefinedType.void) |
There was a problem hiding this comment.
I'm not sure it works. Because we don't support fields for interfaces. How is call supposed to work with structures? I think it's a bug that we allow calls here.
As far as I know, we only support method here, but it's dark magic that we don't use it.
ForNeVeR
commented
Sep 2, 2024
Comment on lines
+210
to
+211
| - sources (the signalling side of a signal): `source("name", signalValueType)` | ||
| - sinks (the receiving side of a signal): `sink("name", signalValueType)` |
There was a problem hiding this comment.
Is this correct? Check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enough is enough.
I propose to merge this as-is (after verifying it's correct) and fill up the remaining parts later.