[TEAMCITY-QA-T] Remove unused build configuration with duplicated fun…

…ctionality (#113)

* Remove unused build configuration, whose functionality exists within different configurations.
* Update VCS root for the sculed build of Windows images.
* Update DSL generator with the removal of deprecated DSL code, just in case.

.teamcity/scheduled/build/TeamCityScheduledImageBuildWindows.kts

@@ -1,6 +1,7 @@
 package scheduled.build
 
 import common.TeamCityDockerImagesRepo.TeamCityDockerImagesRepo
+import common.TeamCityDockerImagesRepo_AllBranches
 import scheduled.build.model.DockerImageInfo
 import utils.dsl.general.teamCityBuildDistDocker
 import jetbrains.buildServer.configs.kotlin.v2019_2.AbsoluteId
@@ -21,7 +22,7 @@ object TeamCityScheduledImageBuildWindows : BuildType({
     name = "TeamCity Docker Images - Automated Scheduled Build - Windows"
 
     vcs {
-        root(TeamCityDockerImagesRepo)
+        root(TeamCityDockerImagesRepo_AllBranches)
     }
 
     steps {
@@ -45,7 +46,7 @@ object TeamCityScheduledImageBuildWindows : BuildType({
         teamCityImageBuildFeatures(requiredSpaceGb = 50)
     }
 
-    // An implicit Windoiws 10 requirement has been added in order to prevent DotNet's WebClient internal exception.
+    // An implicit Windows 10 requirement has been added in order to prevent DotNet's WebClient internal exception.
     requirements {
         contains("teamcity.agent.jvm.os.name", "Windows 10")
     }

.teamcity/settings.kts

@@ -1,6 +1,5 @@
 import common.TeamCityDockerImagesRepo.TeamCityDockerImagesRepo
 import common.TeamCityDockerImagesRepo_AllBranches
-import delivery.BuildAndPushHosted
 import delivery.HubProject
 import delivery.LocalProject
 import scheduled.build.TeamCityDockerImagesScheduledBuild
@@ -17,10 +16,13 @@ object RootProject : Project({
     vcsRoot(TeamCityDockerImagesRepo)
     vcsRoot(TeamCityDockerImagesRepo_AllBranches)
 
+    // Staging registry
     subProject(LocalProject.LocalProject)
+
+    // Production registry
     subProject(HubProject.HubProject)
 
-    buildType(BuildAndPushHosted.BuildAndPushHosted)
+    // Scheduled Builds
     buildType(TeamCityDockerImagesScheduledBuild.TeamCityDockerImagesScheduledBuild)
     buildType(TeamCityScheduledImageBuildWindows.TeamCityScheduledImageBuildWindows)
     buildType(TeamCityScheduledImageBuildLinux_Base("amd64", "linux"))

tool/TeamCity.Docker/TeamCityKotlinSettingsGenerator.cs

@@ -238,8 +238,6 @@ private FileArtifact AddFile(string fileName, IEnumerable<string> lines)
                 "import jetbrains.buildServer.configs.kotlin.v2019_2.triggers.VcsTrigger",
                 "import jetbrains.buildServer.configs.kotlin.v2019_2.triggers.finishBuildTrigger",
                 "import jetbrains.buildServer.configs.kotlin.v2019_2.triggers.vcs",
-                // -- Build Configurations
-                "import hosted.BuildAndPushHosted",
 
                 string.Empty
             };
@@ -483,15 +481,9 @@ private IEnumerable<string> CreateImageValidationConfig(string buildTypeId, IEnu
                 "\t }"
             );
 
+            // Generation of build configuration is deprecated, thus no dependencies are set.
             yield return String.Join('\n',
                	"\n\t dependencies {",
-               	"\t // Dependency on the build of the Docker image",
-               	"\t\t dependency(BuildAndPushHosted.BuildAndPushHosted) {",
-               	"\t\t\t snapshot {",
-               	"\t\t\t\t onDependencyFailure = FailureAction.FAIL_TO_START",
-               	"\t\t\t\t reuseBuilds = ReuseBuilds.SUCCESSFUL",
-               	"\t\t\t }",
-               	"\t\t }",
                	"\t}"
             );