feat(manager): use server metrics row #2354
Conversation
| serverView.totalInboundBytes = totalInboundBytes; | ||
| const NUMBER_OF_ASES_TO_SHOW = 4; | ||
| serverView.bandwidthUsageTotal = this.formatGigabyteValueAndUnit( | ||
| bandwidthUsageTotal / BYTES_IN_GIGABYTES |
There was a problem hiding this comment.
You should pick the unit based on the value. Otherwise you will end up with zeros
| .reverse() | ||
| .map(server => ({ | ||
| title: server.asOrg, | ||
| subtitle: `${server.asn}AS`, |
There was a problem hiding this comment.
Swap. AS must come before the number
| return ''; | ||
| } | ||
|
|
||
| return new Intl.NumberFormat(this.appRoot.language, { |
There was a problem hiding this comment.
Use our existing formatting library to properly pick the units
| .top(NUMBER_OF_ASES_TO_SHOW) | ||
| .reverse() | ||
| .map(server => ({ | ||
| title: server.asOrg, |
There was a problem hiding this comment.
You don't always have asOrg. What's the plan when it's absent?
I usually use ${asOrg} (AS${asn}) with fallback to AS${asn}
| @@ -1101,11 +1172,80 @@ export class App { | |||
| } | |||
| } | |||
|
|
|||
| private formatGigabyteValueAndUnit(data: number) { | |||
| // This happens during app startup before we set the language | |||
There was a problem hiding this comment.
I think this is because we're not setting the default property properly. If you set the default value, you shouldn't need this https://polymer-library.polymer-project.org/3.0/docs/devguide/properties#configure-values
| countryCode.length !== 2 || | ||
| !/^[A-Z]{2}$/.test(countryCode) | ||
| ) { | ||
| return 'Invalid country code'; |
| private countryCodeToEmoji(countryCode: string) { | ||
| if ( | ||
| !countryCode || | ||
| countryCode.length !== 2 || |
There was a problem hiding this comment.
This length check seems redundant given the regular expression also checks the length.
Screen.Recording.2025-01-31.at.3.29.41.PM.mov