Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: J. Yi <[email protected]>
  • Loading branch information
fortuna and jyyi1 authored Nov 6, 2024
1 parent 404aa65 commit b3bdc9e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion transport/split/writer.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ type splitWriterReaderFrom struct {

var _ io.ReaderFrom = (*splitWriterReaderFrom)(nil)

// Split Iterator is a function that returns how many bytes until the next split point, or zero if there are no more splits to do.
// SplitIterator is a function that returns how many bytes until the next split point, or zero if there are no more splits to do.
type SplitIterator func() int64

// NewFixedSplitIterator is a helper function that returns a [SplitIterator] that returns the input number once, followed by zero.
Expand Down
2 changes: 1 addition & 1 deletion x/configurl/split.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func registerSplitStreamDialer(r TypeRegistry[transport.StreamDialer], typeID st
}
bytes, err = strconv.ParseInt(subparts[1], 10, 64)
if err != nil {
return nil, fmt.Errorf("bytes is not a number: %v", subparts[0])
return nil, fmt.Errorf("bytes is not a number: %v", subparts[1])
}
default:
return nil, fmt.Errorf("split format must be a comma-separated list of '[$COUNT*]$BYTES' (e.g. '100,5*2'). Got %v", part)
Expand Down

0 comments on commit b3bdc9e

Please sign in to comment.