Skip to content

Commit

Permalink
Add transport comment.
Browse files Browse the repository at this point in the history
  • Loading branch information
fortuna committed Dec 26, 2023
1 parent 5361291 commit f4d461d
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions x/examples/test-connectivity/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ type connectivityReport struct {
// Inputs
Resolver string `json:"resolver"`
Proto string `json:"proto"`
// TODO(fortuna): get details from trace
// Proxy string `json:"proxy"`
// Prefix string `json:"prefix"`
// TODO(fortuna): add sanitized transport config.
// Transport string `json:"transport"`

// Observations
Time time.Time `json:"time"`
DurationMs int64 `json:"duration_ms"`
Expand Down Expand Up @@ -196,9 +196,8 @@ func main() {
Resolver: resolverAddress,
Proto: proto,
Time: startTime.UTC().Truncate(time.Second),
// TODO(fortuna): Add tracing to get more detailed info:
// Proxy: proxyAddress,
// Prefix: config.Prefix.String(),
// TODO(fortuna): Add sanitized config:
// Transport: config.SanitizedConfig(*transportFlag),
DurationMs: testDuration.Milliseconds(),
Error: makeErrorRecord(result),
}
Expand Down

0 comments on commit f4d461d

Please sign in to comment.