Send connectivity test result to specified report collector #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortuna
reviewed
Oct 23, 2023
Merged
fortuna
reviewed
Oct 25, 2023
fortuna
approved these changes
Oct 25, 2023
|
Let's merge this, and iterate on the reporter library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a new branch for this since I messed up the previous branch when doing unnecessary rebase and addressing merge conflicts :(
I moved all the changes to this branch and also implement failure and success sample rate flags to send reports with a given probability. I also added an optional port flag. There should not be any merge conflict with merge since I fetched upstream before making this branch.
I am going to close the other pull request.