Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: HTTP proxy #125

Merged
merged 1 commit into from
Oct 26, 2023
Merged

cleanup: HTTP proxy #125

merged 1 commit into from
Oct 26, 2023

Conversation

fortuna
Copy link
Contributor

@fortuna fortuna commented Oct 26, 2023

I'm separating the components and making them independently reusable, while I was looking into passing parameters to the CONNECT handler.

@fortuna fortuna requested a review from jyyi1 October 26, 2023 22:33
@fortuna fortuna enabled auto-merge (squash) October 26, 2023 22:33
jyyi1
jyyi1 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fortuna fortuna merged commit 01a1746 into main Oct 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyyi1 jyyi1 jyyi1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fortuna @jyyi1