feat: no-buffer split #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyyi1
approved these changes
Nov 2, 2023
transport/split/writer.go
Outdated
| n, err := io.Copy(w.writer, source) | ||
| written += n | ||
| func (w *splitWriterReaderFrom) ReadFrom(source io.Reader) (int64, error) { | ||
| written, err := w.ReaderFrom.ReadFrom(&splitReader{source, w.prefixBytes}) |
There was a problem hiding this comment.
An alternative way is to reuse io's standard readers. I'm ok with both, you can choose whichever one you prefer.
Suggested change
| written, err := w.ReaderFrom.ReadFrom(&splitReader{source, w.prefixBytes}) | |
| limit := io.LimitReader(source, w.prefixBytes) | |
| split := io.MultiReader(limit, source) | |
| written, err := w.ReaderFrom.ReadFrom(split) |
There was a problem hiding this comment.
Sounds good. Less code to maintain.
Co-authored-by: J. Yi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ReadFrom call no longer needs to allocate a buffer now. The buffer is provided by the inner ReaderFrom.
We should prefer ReadFrom when possible to avoid unnecessary buffers, but it needs to be properly implemented. This is an example of how we can accomplish that.