Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 5s timeout to http.Client #130

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

nimaadib
Copy link
Contributor

@nimaadib nimaadib commented Nov 1, 2023

The GET requests would stuck for a long time if the connections are being interrupted/blocked.

Copy link

google-cla bot commented Nov 1, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
I need you to accept the CLA in order to merge this change.

@nimaadib
Copy link
Contributor Author

nimaadib commented Nov 1, 2023

Thanks for the contribution! I need you to accept the CLA in order to merge this change.

Done.

@fortuna fortuna merged commit 85ede5b into Jigsaw-Code:main Nov 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants