New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try ReaderFrom #131

Draft

fortuna wants to merge 3 commits into main from fortuna/readfrom

Contributor

fortuna commented Nov 2, 2023

No description provided.


          Try ReaderFrom

8257d95

github-advanced-security bot found potential problems

View reviewed changes

transport/socks5/stream_dialer.go

    
              	if header[1] != 0 {

              		return nil, ReplyCode(header[1])

              	if response[1] != 0 {

              		return nil, ReplyCode(response[1])

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types High

Incorrect conversion of an integer with architecture-dependent bit size from

strconv.Atoi

to a lower bit size type uint8 without an upper bound check.
Incorrect conversion of an integer with architecture-dependent bit size from

strconv.Atoi

to a lower bit size type uint8 without an upper bound check.

Contributor Author

fortuna commented Nov 2, 2023

@jyyi1 This is a preview of what removing Write and using ReaderFrom looks like. Still broken though.

fortuna added 2 commits

November 1, 2023 20:25


          Rename Writer

d3657a8


          Remove Reader

a4baed4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet