Refactoring Outline Connectivity example using report package #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amircybersec
commented
Nov 28, 2023
amircybersec
commented
- Outline Connectivity is now using report package to collect connectivity report
- This PR fixes an issue with report package where Collector type struct fields could not be exported and used externally
|
@fortuna could you please review this PR for me when you have a moment? I also refactored the outline connectivity app with report package and wanted to do a PR for that but since there's some dependencies on the fixes I made to reporter package in this PR, I'd rather wait until this is merged to main before open the other PR. |
fortuna
requested changes
Nov 30, 2023
|
@fortuna Thanks a lot for the feedback! Applied the suggested changes |
fortuna
approved these changes
Nov 30, 2023
|
@fortuna thanks for the quick review! I don't seem to have write access to the repo and cannot merge this. could you please do me a favor and merge these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.