chore: update examples to use new dns package #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is partially superseded by #146. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fortuna
force-pushed
the
fortuna-dns-clean
branch
from
6ac3c5f to
df90c43
Compare
fortuna
force-pushed
the
fortuna-dns-examples
branch
2 times, most recently
from
fd3fd8d to
0cf7957
Compare
Update resolve
fortuna
force-pushed
the
fortuna-dns-examples
branch
from
0cf7957 to
1c4e03a
Compare
|
@jyyi1 any thoughts? |
fortuna
commented
Jan 12, 2024
Co-authored-by: J. Yi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates code in the examples folder to use the code from #141.
Note that the connectivity test had to be revamped, but got simplified.
This PR completely removes our dependency on
github.com/miekg/dns./cc @amircybersec