Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: revamp README #151

Merged
merged 5 commits into from
Jan 2, 2024
Merged

chore: revamp README #151

merged 5 commits into from
Jan 2, 2024

Conversation

fortuna
Copy link
Contributor

@fortuna fortuna commented Dec 28, 2023

In the process I enhanced the fetch tool to make the example more compelling.

@fortuna fortuna requested a review from jyyi1 December 28, 2023 23:59
@fortuna
Copy link
Contributor Author

fortuna commented Dec 29, 2023

@hilary-ops, would you mind reviewing this PR?

jyyi1
jyyi1 approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This LGTM, with a few minor comments.

x/examples/fetch/main.go Outdated Show resolved Hide resolved
x/examples/fetch/main.go Outdated Show resolved Hide resolved
x/examples/fetch/main.go Outdated Show resolved Hide resolved
@jyyi1 jyyi1 changed the title Revamp README chore: revamp README Jan 2, 2024
@fortuna fortuna merged commit 0488092 into main Jan 2, 2024
6 checks passed
@fortuna fortuna deleted the fortuna-docs branch January 2, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyyi1 jyyi1 jyyi1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fortuna @jyyi1