feat: introduce address override #155
Conversation
| return func(address string) (string, error) { | ||
| host, port, err := net.SplitHostPort(address) | ||
| if err != nil { | ||
| return "", fmt.Errorf("address is not valid host:port: %w", err) |
There was a problem hiding this comment.
Instead of returning an error, we may also return hostOverride + ":" + portOverride here if hostOverride != "" && portOverride != "".
Co-authored-by: J. Yi <[email protected]>
|
Comments addressed. On the naming, it means "address override". We can override the host or the port, so names with "domain" or "host" are not the right scope. "Resolve" also doesn't apply, since we can override the host with a domain. I thought about using "map", but there's no key to lookup. Perhaps
|
| return func(address string) (string, error) { | ||
| host, port, err := net.SplitHostPort(address) | ||
| if err != nil { | ||
| return "", fmt.Errorf("address is not valid host:port: %w", err) |
| @@ -143,7 +145,7 @@ The [`fetch` tool](https://pkg.go.dev/github.com/Jigsaw-Code/outline-sdk/x/examp | |||
| a URL, similar to `curl`. The example below would bypass blocking of `meduza.io` in Russia: | |||
|
|
|||
| ```console | |||
| $ go run github.com/Jigsaw-Code/outline-sdk/x/examples/fetch@latest -transport "tlsfrag:1" -method HEAD -v -address "cloudflare.net" https://meduza.io/ | |||
| $ go run github.com/Jigsaw-Code/outline-sdk/x/examples/fetch@latest -transport "override:host=cloudflare.net|tlsfrag:1" -method HEAD -v https://meduza.io/ | |||
There was a problem hiding this comment.
I updated the examples to show that we don't need an application change anymore with override.
What I'm worried about the naming |
|
This is a Dialer specification. The only thing a Dialer sees is an address, so there won't be a need to specify other overrides, unless we introduce some sort of modifier, but that's a whole can of worms. We could use |
This is a feature I've been wanting for a while that helps with debugging and can be used to bypass DNS censorship.