Create Tools App #169
Merged
Create Tools App #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellacosse
approved these changes
Jan 24, 2024
| return t.Color(theme.ColorNamePrimary, variant) | ||
| case theme.ColorNamePrimary: | ||
| if variant == theme.VariantLight { | ||
| return color.RGBA{R: 0x00, G: 0x67, B: 0x7F, A: 255} |
There was a problem hiding this comment.
nit: RGB is pretty unintuitive, I have no idea what color this is by looking at the code. Mind either assigning these to well-named variables or just commenting what colors they are?
There was a problem hiding this comment.
Added comments. Unfortunately there's no HSL support in Fyne or Go's color package.
| aBox.SetText("❌ " + err.Error()) | ||
| } else { | ||
| texts := make([]string, len(ips)) | ||
| for ii, ip := range ips { |
There was a problem hiding this comment.
annoying there's no map function
There was a problem hiding this comment.
Agreed. Though the code is quite readable this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helped me debug the CNAME lookup on Android, and come up with a solution.