Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add instructions to build for Windows on macOS #216

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Conversation

fortuna
Copy link
Contributor

@fortuna fortuna commented Apr 4, 2024

No description provided.

@fortuna fortuna requested review from jyyi1 and amircybersec April 4, 2024 21:25
Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is also how we can build Outline Client natively from macOS.

Comment on lines 21 to 23
From macOS, you can build the app for Windows with MinGW.

First install MinGW:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, Mingw-w64 is a fork of the original mingw (a.k.a., mingw32) and is maintained by different devs.

Suggested change
From macOS, you can build the app for Windows with MinGW.
First install MinGW:
From macOS, you can build the app for Windows with Mingw-w64.
First install Mingw-w64:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

GOOS=windows GOARCH=amd64 CGO_ENABLED=1 CC="x86_64-w64-mingw32-gcc" go build .
```

32-bit:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking whether we should still put 32-bit build instructions here, are there any real world PCs that are still 32 bit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. removed the 32-bit instructions.

x/examples/fyne-tools/README.md Show resolved Hide resolved
@fortuna fortuna requested a review from jyyi1 April 5, 2024 16:21
Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fortuna fortuna merged commit dda5b92 into main Apr 5, 2024
6 checks passed
@fortuna fortuna deleted the fortuna-xplat branch April 5, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants