Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x): add h3/QUIC support to the fetch tool #305
feat(x): add h3/QUIC support to the fetch tool #305
Changes from 37 commits
b15bb9b
845dfa6
470bdd3
bb0a827
550384b
5826709
22a0526
f2938cf
17182e0
77906f1
ffc0654
7df7d2c
d3712d1
67a190c
6803dde
7431238
92eca9d
f194150
76bcf64
866f9c1
eb793dc
a848931
0e483c7
b3fbf2b
308ff7d
ffbdf49
fadf314
47c9ad6
a716c1f
b3fec8a
f9b97cd
6783ebf
34682f1
3fae6e0
ec133fe
3e1442c
ad2492d
e245a9a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that
os.Exit
will bypass alldefer
calls, I guess it's OK in this PR since all resources will be cleaned up when the process ends.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Though I'll also add that this is no different from what we currently have with the Fatal calls, which calls os.Exit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, quic-go requires 1.22. We'll need to keep this quite recent in order to support newer protocol updates, unfortunately.