Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create opts package #316
feat: create opts package #316
Changes from 2 commits
74e5fe2
bbf6f92
b7aaba9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we create a new
conn
here, is it the same as the oldconn
(passed in through the parameter)? What are the relationship between them?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
ipv4
/ipv6
packages have this Conn abstraction that is only used to set options. It's not technically a connection, more like an options interface:I've renamed the local one to
ipConn
to avoid confusions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, it wraps around an existing
fd
, though the source code is actually located in thenet
package rather than thex/net
: https://cs.opensource.google/go/go/+/master:src/net/rawconn.go;l=79;drc=9088883cf4a5181cf796c968bbce5a5bc3edc7abThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to accept a
TCPConn
? Can we just accept anet.Conn
and returns error if it's not aTCPConn
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it doesn't accept every type of net.Conn. I would rather be explicit about it.
Also, options for UDP may differ from options for TCP.