Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x): use coder implementation in ws2endpoint #362

Closed
wants to merge 2 commits into from
Closed

Conversation

fortuna
Copy link
Contributor

@fortuna fortuna commented Jan 29, 2025

We may or may not want to use this. Ideally we would extract a reusable handler based on gorilla into the websocket package.

This was useful for me to validate the client.

Run reverse proxy:

go run ./examples/ws2endpoint -backend example.com:443

Fetch over websocket:

go run ./examples/fetch -v -transport "override:host=127.0.0.1&port=8080|ws:tcp_path=/tcp" https://example.com:80

@fortuna fortuna requested a review from sbruens January 29, 2025 22:49
@fortuna
Copy link
Contributor Author

fortuna commented Jan 29, 2025

Perhaps we should prefer #363

@fortuna
Copy link
Contributor Author

fortuna commented Jan 30, 2025

I'll close this one since we have #363 working.

We should update the code to use your Update function later

@fortuna fortuna closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants