Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix android project path #87

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

daniellacosse
Copy link
Contributor

I broke the pathing when I changed the app ID in the last pr 😅

@daniellacosse daniellacosse requested review from fortuna and jyyi1 October 6, 2023 18:58
dirs "../capacitor-cordova-android-plugins/src/main/libs", "libs"
dirs "/Users/avaldez/Documents/code/outline-sdk/x/examples/outline-connectivity-app/shared_backend/output"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A kindly reminder, will this username cause any potential security breaches?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, not much we can do about it now. Do you have any ideas how it might?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with doing nothing, if it's already a public info (like my username).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it is

@daniellacosse daniellacosse merged commit 12bb31b into main Oct 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants