Rewrite of Script in Python with more configuration options #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded more flexible configuration for autobackup parameters, logging and smtp/mail.
Added autobackup parameters to config. Extended trigger.sh to install this script and dependencies from github.
Updated .gitignore to exclude __pycache__/ venv/ and config.yaml
Deleted old backup.sh and monitor.py
Simplified checkout code.
Changing to git init and then git remode add.
Added description for failing PyYML Fixed error in import of zfs-autobackup
|
Nice to see you've picked up development of udev-trigger-zfs-autobackup. As I'm currently not using this myself and not maintaining this repo I won't merge this. Instead I hope others will find your fork by leaving this pull request open. |
…importing/exporting the pool. Removed 'set -eu' because they hid errors.
…put. This might solve an issue where zfs-autobackup threw an error when writing to std:err. Also removed redundant zfs_tag from config.
…space. Spaces are not allowed unless escaped and mess up the command line parameters. It's true by default but can be turned off. This fixes #1
Create LICENSE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rewrote most of the script to work only with python (except the trigger.sh) with more config options (zfs-autobackup parameters), install options, logging and email on success or error. Tested on my TrueNAS Scale.
You would need to change REPO_URL in trigger.sh to your own repo after merging this PR.