Basic setup for Java 21 #139
Conversation
* Adjust code so the symbol for currency XXX remains as XXX
WalkthroughWalkthroughThe overall changes involve updating the Java compatibility of the Joda-Money library and its associated configuration files. The Java version has been upgraded from 11 to 21 in the build process, aligning the library with modern standards. Additionally, version compatibility details and dependency information in the documentation have been clarified, ensuring users understand the implications of using different versions. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Joda-Money
participant GitHub Actions
User->>GitHub Actions: Push code
GitHub Actions->>Joda-Money: Build with Java 21
Joda-Money->>GitHub Actions: Return build status
GitHub Actions->>User: Notify build result
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
|
@coderabbitai review |
Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- .github/workflows/build.yml (1 hunks)
- README.md (2 hunks)
- pom.xml (7 hunks)
- src/changes/changes.xml (1 hunks)
- src/site/markdown/index.md (1 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/build.yml
Additional comments not posted (9)
README.md (1)
53-61: Clarification on version compatibility and dependencies is well done.The updates to the version compatibility and dependency information enhance clarity for users. These changes clearly communicate the requirements for different versions of the library.
src/site/markdown/index.md (1)
73-79: Consistency in documentation updates is appreciated.The changes maintain consistency with the
README.mdupdates, ensuring that users receive the same information across different documentation sources.src/changes/changes.xml (1)
11-15: Addition of new release entry is clear and informative.The new release entry for version
2.0.0-RC1effectively communicates the major changes and compatibility with Java SE 21.pom.xml (6)
12-13: Version and description updates align with Java 21 compatibility.The version and description updates reflect the project's alignment with Java 21, ensuring users are aware of the new compatibility requirements.
Line range hint
103-119: Enforcement of Maven and Java versions is a good practice.Updating the Maven Enforcer Plugin to require Maven 3.8.0 and Java 21 ensures that the build environment is consistent with the project's requirements.
202-204: Javadoc configuration updated for Java 21.The Javadoc plugin configuration now uses Java 21, aligning documentation generation with the latest language features.
554-554: Surefire report configuration remains consistent with the new Java version.The Surefire report plugin configuration is updated to reflect Java 21, ensuring test reports are generated correctly.
808-809: Compiler properties updated for Java 21.The Maven compiler plugin properties now target Java 21, streamlining the build process for the latest Java version.
818-818: Checkstyle plugin version update is beneficial.Updating the Checkstyle plugin to version 10.17.0 may introduce new rules and improvements, enhancing code quality checks.
* Adjust code so the symbol for currency XXX remains as XXX
Summary by CodeRabbit
New Features
2.0.0-RC1with compatibility for Java SE 21 or later.Documentation
Bug Fixes