Skip to content

Commit

Permalink
Clean up the headers
Browse files Browse the repository at this point in the history
  • Loading branch information
yingsu00 authored and Joe-Abraham committed Sep 2, 2024
1 parent c112925 commit 31b2995
Show file tree
Hide file tree
Showing 12 changed files with 29 additions and 14 deletions.
3 changes: 1 addition & 2 deletions velox/common/base/Exceptions.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,8 @@
#include <sstream>

#include <fmt/format.h>
#include <folly/Preprocessor.h>

#include <fmt/ostream.h>
#include <folly/Preprocessor.h>

#include "velox/common/base/FmtStdFormatters.h"
#include "velox/common/base/VeloxException.h"
Expand Down
1 change: 1 addition & 0 deletions velox/common/base/Fs.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/

#include "velox/common/base/Fs.h"

#include <fmt/format.h>
#include <glog/logging.h>

Expand Down
5 changes: 3 additions & 2 deletions velox/common/base/RuntimeMetrics.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,12 @@

#pragma once

#include <fmt/format.h>
#include <folly/CppAttributes.h>
#include <limits>
#include <sstream>

#include <fmt/format.h>
#include <folly/CppAttributes.h>

namespace facebook::velox {

struct RuntimeCounter {
Expand Down
2 changes: 2 additions & 0 deletions velox/common/base/SpillStats.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,12 @@
* limitations under the License.
*/
#pragma once

#include <stdint.h>
#include <string.h>

#include <folly/executors/CPUThreadPoolExecutor.h>

#include "velox/common/compression/Compression.h"

namespace facebook::velox::common {
Expand Down
5 changes: 3 additions & 2 deletions velox/common/base/Status.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,13 @@

#pragma once

#include <string>
#include <utility>

#include <fmt/format.h>
#include <fmt/ostream.h>
#include <folly/Expected.h>
#include <folly/Likely.h>
#include <string>
#include <utility>

namespace facebook::velox {

Expand Down
3 changes: 2 additions & 1 deletion velox/common/caching/AsyncDataCache.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,11 @@
#include <deque>

#include <fmt/format.h>
#include <folly/GLog.h>
#include <folly/chrono/Hardware.h>
#include <folly/container/F14Set.h>
#include <folly/futures/SharedPromise.h>
#include "folly/GLog.h"

#include "velox/common/base/BitUtil.h"
#include "velox/common/base/CoalesceIo.h"
#include "velox/common/base/Portability.h"
Expand Down
7 changes: 5 additions & 2 deletions velox/dwio/catalog/fbhive/FileUtils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,12 @@
*/

#include "FileUtils.h"
#include <fmt/core.h>

#include <bitset>
#include "folly/container/Array.h"

#include <fmt/core.h>
#include <folly/container/Array.h>

#include "velox/dwio/common/exception/Exception.h"

namespace facebook {
Expand Down
2 changes: 2 additions & 0 deletions velox/exec/Driver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,12 @@
*/

#include "velox/exec/Driver.h"

#include <folly/ScopeGuard.h>
#include <folly/executors/QueuedImmediateExecutor.h>
#include <folly/executors/thread_factory/InitThreadFactory.h>
#include <gflags/gflags.h>

#include "velox/common/base/Counters.h"
#include "velox/common/base/StatsReporter.h"
#include "velox/common/process/TraceContext.h"
Expand Down
4 changes: 3 additions & 1 deletion velox/exec/Driver.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,12 @@
* limitations under the License.
*/
#pragma once

#include <memory>

#include <folly/executors/CPUThreadPoolExecutor.h>
#include <folly/futures/Future.h>
#include <folly/portability/SysSyscall.h>
#include <memory>

#include "velox/common/base/Counters.h"
#include "velox/common/base/StatsReporter.h"
Expand Down
1 change: 1 addition & 0 deletions velox/exec/Task.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
* limitations under the License.
*/
#pragma once

#include "velox/core/PlanFragment.h"
#include "velox/core/QueryCtx.h"
#include "velox/exec/Driver.h"
Expand Down
7 changes: 4 additions & 3 deletions velox/exec/tests/TableScanTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,14 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include <atomic>
#include <shared_mutex>

#include <fmt/ranges.h>
#include <folly/experimental/EventCount.h>
#include <folly/synchronization/Baton.h>
#include <folly/synchronization/Latch.h>
#include <atomic>
#include <shared_mutex>

#include "folly/experimental/EventCount.h"
#include "velox/common/base/Fs.h"
#include "velox/common/base/tests/GTestUtils.h"
#include "velox/common/file/tests/FaultyFile.h"
Expand Down
3 changes: 2 additions & 1 deletion velox/type/fbhive/HiveTypeParser.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
#include <string>
#include <vector>

#include "folly/Range.h"
#include <folly/Range.h>

#include "velox/type/TypeParser.h"

namespace facebook::velox::type::fbhive {
Expand Down

0 comments on commit 31b2995

Please sign in to comment.