Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(nimble selective reader): Extract common deduplicated reader…
… helper class (facebookincubator#11766) Summary: Pull Request resolved: facebookincubator#11766 Extract deduplicated reader helper class to share common logic between DeduplicatedArrayColumnReader and DeduplicatedMapColumnReader. This class essentially wants to be a DeduplicatedColumnReaderBase, that inherits velox::common::SelectiveRepeatedColumnReader. This pattern is adopted because we can't both inherit from DeduplicatedColumnReaderBase and the specific column readers, without forcing virtual inheritance, or duplicating all other methods from the specific parent classes. Reviewed By: Yuhta Differential Revision: D66812388 fbshipit-source-id: 3a72dcd77acb01e9e4361f0ef9bffc90a98ce385
- Loading branch information