Skip to content

Commit

Permalink
fix: Delta update reader lifecycle issue (facebookincubator#11639)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebookincubator#11639

In ScanSpec we only clear the column updater for root but not the
actual columns, this results in lifecycle issue when a non-Metalake split is
following a Makelake split.

bypass-github-export-checks

Reviewed By: amitkdutta

Differential Revision: D66402400

fbshipit-source-id: 88c8280252aa563ce058729b8caf0c38b660edd1
  • Loading branch information
Yuhta authored and facebook-github-bot committed Nov 24, 2024
1 parent bf3fba7 commit 78d761b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion velox/dwio/common/ScanSpec.h
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ class ScanSpec {
for (auto& child : children_) {
// Only top level columns can have delta updates.
if (child->deltaUpdate_) {
setDeltaUpdate(nullptr);
child->setDeltaUpdate(nullptr);
}
}
}
Expand Down

0 comments on commit 78d761b

Please sign in to comment.