-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert a newline for empty single-line documentation comments #917
Insert a newline for empty single-line documentation comments #917
Conversation
Thanks for this! Can you also add a test case to |
Whoops, wrong button |
I'm not sure if this is the best way to add a test like this, because I feel like this is a much more complicated and nuanced test. Probably what would need to happen is every use of multiline comments (or vice versa) in Ideally, the end goal should probably always be congruence between multiline and single-line doc comments, such that someone could replace the |
This test makes sense to me! Although it looks like it is failing? I also fixed a compilation error and added a simpler test case. I'm not sure what is the expected end result of the test you added though - it looks like the number of newlines between the singleline and multiline definitions are different? Could you also add this to the changelog? |
The idea was just to check if single-line documentation comments were equivalent to multi-line documentation comments but honestly the test you added is better and covers what we actually needed so I think I'll just go ahead and remove the one I made, C++ is cruel 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clear, thank you!
This PR makes empty single-line documentation comments act as newlines.
This change fixes #905 and aligns single-line comments with multi-line comments, making them essentially equivalent as far as I can tell.