Feat: Remove retry mechanism #3835

iamsamgibbs · 2024-12-03T16:58:45Z

Description

This PR removes the "Retry" mechanism from the UserHub. The retry mechanism was inherently flawed as it would only retry individual transactions, not entire sagas, meaning any mutations or nuances of the saga would be missed on a reattempt. The intention going forward is that actions should be retry-able from where they are created, which will be properly implemented after #2528 is complete as it will make retrying actions much simpler.

This PR also adds a temporary retry system to the create colony flow (which is currently broken on master) but this should be replaced in the future.

Testing

Step 1 - Connect with the metamask wallet and clear your activity tab data under advanced settings.

Step 2 - Create an action and reject the transaction in the metamask popup

Step 3 - Ensure the UserHub transactions list pops opens automatically and shows the transaction as failed. There should be no "Retry" option.

Step 4 - Run node scripts/create-colony-url.js and open the link
Step 5 - Follow through all the steps choosing to create a new token
Step 6 - When you submit the form, reject the first transaction. You should be returned to the confirmation screen. Note the error toast too.

Screen.Recording.2024-12-04.at.14.38.21.mov

Step 7 - Resubmit the form, accept the first transaction but reject the second one. On master, this would stay on the same screen and let you retry the SetOwner transaction. However, regardless of whether that transaction succeeded or failed, it would not progress to the following transactions. This PR adjusts this step to show a new error message and properly allow retrying the subsequent transactions. It isn't pretty as this is only a temporary implementation and should be replaced when Refactor: Transactions API #2528 is complete which will allow actions to be properly retried.

Screen.Recording.2024-12-04.at.16.52.17.mov

Step 8 - Click retry, accept the first transaction but reject the second one. (Note, it may take some time for the transaction to appear).

Screen.Recording.2024-12-04.at.17.02.24.mov

Step 9 - Expect to see a different error, this time the SetOwner transaction has succeeded, but the extension related transactions failed. At this point the extensions can be manually installed in the colony itself so we can click the link to navigate to the colony. (Rather than implementing another temporary saga just for this edge case).
Step 10 - Repeat the create colony process. This time accept the first two transactions and reject the third. You should skip the retry stage and just go straight to the extension error notice.

Screen.Recording.2024-12-04.at.17.05.45.mov

Step 11 - Repeat the create colony process one more time. This time accept all the transactions and check the flow works as expected.

Screen.Recording.2024-12-04.at.17.06.46.mov

Diffs

Changes 🏗

Added temporary "finishCreateColony" saga and adjusts the create colony flow to make retrying possible

Deletions ⚰️

Removed unused "TransactionsItem" component and styles
Removed any uses of the transaction retry system

Resolves #3707
Resolves #3549

mmioana

Really nice work on fixing these issues @iamsamgibbs 🥇

Cleared the metamask activity

Created a Simple payment and rejected the transaction

The transaction appeared in the UserHub without the retry button

Created a new colony and this is before form submission

Rejected the first transaction

Resubmitted the form and accepted the 1st transaction

But rejected the 2nd transaction

Got redirected to the retry screen

Accepted all transactions

And got redirected to the new colony page

Then created a new colony, confirmed the first transaction and rejected the 2nd to get to the retry screen. Then accepted the 1st transaction and rejected the 2nd

Pressed the Go to your colony link