Fix: Advanced payments file upload errors #4171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmioana
changed the title
iamsamgibbs
previously approved these changes
Jan 27, 2025
Fix: Update file upload modal description
Fix: Update file upload error message
mmioana
force-pushed
the
fix/3715-advanced-payments-csv-error
branch
from
38d38c4 to
8874caf
Compare
mmioana
commented
Jan 29, 2025
| @@ -40,7 +44,7 @@ const MSG = defineMessages({ | |||
| }, | |||
| fileMinDimensionsError: { | |||
| id: `${displayName}.fileMinDimensionsError`, | |||
| defaultMessage: 'Image dimensions should be at least 120x120px', | |||
| defaultMessage: 'Image dimensions should be at least {fileDimension}', | |||
There was a problem hiding this comment.
Took the change to refactor this message to be more dynamical based on the provisioned fileDimension prop
|
Hey @iamsamgibbs thanks for your review. Unfortunately had to rebase, so your review got dismissed :( |
davecreaser
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Really nice @mmioana, super clean changes and fixes.
CSV message and errors are correct:
And it still accepts a correct input:
I also checked the user avatar error just to be sure, and all good there:
iamsamgibbs
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
structureandtoo-large-content(aka too many rows) errors when uploading a file for theAdvanced Paymentaction, by adding a brand new errorDropzoneErrors.CONTENT_TOO_LARGE. Too make the message more dynamical, thefileOptionsvalues can now be used in the error message descriptors.react-dropzonewill not consider a file upload failed if the options provided will be fulfilled, but the file upload handler will set an error, so the filename will not be available for display in the error component. Thus, I have added afallbackFileNameproperty to theFileUploadProps.Testing
TODO: Let's test the changes are working as expected.
Step 1. Open the
Advanced PaymentactionStep 2. Click the
Upload CSVbutton underneath the tableStep 3. Check the modal description has been updated to
Bulk upload up to 400 recipients using a CSV. Use the template to ensure the correct structure, be sure to remove the sample data.Step 4. Now upload this file content-too-large.csv and make sure you get this error
Step 5. Upload this other file wrong-structure.csv and make sure you get this error
Step 6. Now try this file correct-structure.csv and you should not get any error in the modal, but should see the rows filled in the payment table
Screen.Recording.2025-01-27.at.09.56.54.mov
Important
Some user addresses will not be of known users, but you can change that before uploading the
.csv, however it is not mandatory.If you have any other testing scenarios coming to mind, please try them out 🎉
Diffs
New stuff ✨
CONTENT_TOO_LARGEtoDropzoneErrorsfallbackFileNametoFileUploadPropsChanges 🏗
isAvatarUploadedtoisFileUploadedinFileUploadPropsResolves #3715