Fix: Button with icon bug #4194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmioana
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Awesome work @iamsamgibbs!
Now the incoming funds page filter has the right label and the spacing between the text and the icon is correct for both the filter button and save draft button 🎉
Nice!
davecreaser
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Nice one @iamsamgibbs - a short and sweet PR 😆
Checked all the filters buttons I could think of and all looks good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves an issue where the "save draft" button and "filters" button had too much big of a gap between the icon and the text.
Testing
Check all instances of the filters buttons.
Check the filter button on the incoming funds page reads "All filters".
Check the "Save draft" button for creating agreements has the correct spacing.
Diffs
Changes 🏗
Deletions ⚰️
Resolves #3351