Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use contributorAddress when no user wallet address found #4246

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

iamsamgibbs
Copy link
Contributor

Description

This PR fixes an issue where blockies were not being properly generated for colony members who no longer had user accounts.

Testing

  • Step 1 - We need to delete some user accounts to replicate the production scenario. Go to http://localhost:9091/planex/members/followers.

  • Step 2 - Ignore our dev wallet pals, but copy the wallet address of the first non-dev wallet follower.

  • Step 3 - Run the following mutation in graphiql to delete the user.

mutation MyMutation {
  deleteUser(input: {id: "<USER_ADDRESS>"}) {
    id
  }
}
  • Step 4 - Repeat for the first few users.
  • Step 5 - Refresh and create a simple payment action.
  • Step 6 - Open the recipient list, each user should have a unique blockie.

Screenshot 2025-02-05 at 12 09 14

Compared to master:

Screenshot 2025-02-05 at 12 09 04

Diffs

Changes 🏗

  • Fallback to member.contributorAddress is no user wallet address found.

Resolves #3969

@iamsamgibbs iamsamgibbs self-assigned this Feb 5, 2025
@iamsamgibbs iamsamgibbs marked this pull request as ready for review February 5, 2025 12:19
@iamsamgibbs iamsamgibbs requested a review from a team as a code owner February 5, 2025 12:19
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

Copy link
Collaborator

@jakubcolony jakubcolony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👌

image

Copy link
Contributor

@mmioana mmioana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice fix @iamsamgibbs 🎉

Went to the followers list and deleted some of the existing users' profile
Screenshot 2025-02-06 at 09 40 11

Opened the user select dropdown and different blockies showed up
Screenshot 2025-02-06 at 09 41 29

While on master 🙈
Screenshot 2025-02-06 at 09 41 37

Nice!!! 💯

@iamsamgibbs iamsamgibbs merged commit dcefdc8 into master Feb 6, 2025
2 checks passed
@iamsamgibbs iamsamgibbs deleted the fix/3969-blockies-not-generated-for-non-users branch February 6, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PROD] Blockies not generating correctly within actions
4 participants