Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Team name max length should not be enforced on input #4247

Conversation

iamsamgibbs
Copy link
Contributor

Description

This PR removes the max length restriction from the input in the InputBase component. The component should instead show currentLength / maxLength in the UI next to the input and not restrict the max length on the input itself. The form validation still restricts submitting a name which exceeds the max length.

I could not find any other places where this component is consumed that uses the maxLength property so do not believe it breaks anything elsewhere, but please do check.

Testing

Create an "Edit team" or "Create team" action and enter a team name that exceeds the 20 character limit. You should be able to keep typing past the character limit and the currentLength / maxLength UI should display.

Screenshot 2025-02-05 at 12 42 10

Screenshot 2025-02-05 at 12 42 21

Diffs

Deletions ⚰️

  • Removed the max length restriction from the input in the InputBase component.

Resolves #3993

@iamsamgibbs iamsamgibbs self-assigned this Feb 5, 2025
@iamsamgibbs iamsamgibbs marked this pull request as ready for review February 5, 2025 12:48
@iamsamgibbs iamsamgibbs requested a review from a team as a code owner February 5, 2025 12:48
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go again :)

Copy link
Contributor

@rumzledz rumzledz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another one finessed @iamsamgibbs 🔥

image

Copy link
Collaborator

@jakubcolony jakubcolony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@iamsamgibbs iamsamgibbs merged commit 57d5a3c into master Feb 6, 2025
2 checks passed
@iamsamgibbs iamsamgibbs deleted the fix/3993-team-name-max-length-should-not-be-enforced-on-input branch February 6, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PROD] Team name fields incorrectly disables input
4 participants