Fix: Team name max length should not be enforced on input #4247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the max length restriction from the input in the
InputBase
component. The component should instead showcurrentLength / maxLength
in the UI next to the input and not restrict the max length on the input itself. The form validation still restricts submitting a name which exceeds the max length.I could not find any other places where this component is consumed that uses the maxLength property so do not believe it breaks anything elsewhere, but please do check.
Testing
Create an "Edit team" or "Create team" action and enter a team name that exceeds the 20 character limit. You should be able to keep typing past the character limit and the
currentLength / maxLength
UI should display.Diffs
Deletions ⚰️
InputBase
component.Resolves #3993