Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DAO incorporation option #4141

Open
wants to merge 10 commits into
base: feature/advanced-expenditures
Choose a base branch
from

Conversation

agnieszkajarosikloj
Copy link

@agnieszkajarosikloj agnieszkajarosikloj commented Jan 23, 2023

Description

This PR adds DAO incorporation option.
New "DAO Incorporation" option in the Advanced options of the New Action modal.
This PR adds only this option, action triggered after clicking on the option will be added in the next PR, with the info modal.

New stuff

  • DAO incorporation option
  • flag icon

Figma link
https://www.figma.com/file/fmnKIUY0LGfEnsOOQloVVX/Korporatio?node-id=976%3A125871&t=qe6VTZuthI6cqA3s-0

Screenshot 2023-01-31 at 23 26 57

Resolves #4139

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@agnieszkajarosikloj agnieszkajarosikloj requested a review from a team January 26, 2023 05:27
Copy link
Member

@arrenv arrenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agnieszkajarosikloj Mostly good, except this should be within the Advanced modal section, not under the Advanced modal.

@agnieszkajarosikloj agnieszkajarosikloj force-pushed the feature/4139-DAO-incorporation-option branch from 3b60cdf to 164ee32 Compare January 31, 2023 22:30
@agnieszkajarosikloj
Copy link
Author

@arrenv I added a fix.

Copy link
Member

@arrenv arrenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agnieszkajarosikloj Looks good, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants