Switch from solparse to solidity-parser #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like solparse is getting integrated into solidity-parser (see here) and other parser fixes are being channelled there as well. For example this change to allow expressions as modifier arguments is needed to be able to run against functions like this in zeppelin-solidity where
sha3
is invoked within a modifier call.This PR:
package.json
(fetching from the github master)requires
and runs solidity-parser ininstrumentSolidity.js
.