fix(common): redundant store_cache removed (#472)

* fix(common): redundant store_cache removed * fix(common): ipc provider address is not an url --------- Co-authored-by: Jonathan Becker <[email protected]>
Jon-Becker · Jul 28, 2024 · e50c086 · e50c086
1 parent 9133646
commit e50c086
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/crates/common/src/ether/provider.rs b/crates/common/src/ether/provider.rs
@@ -32,9 +32,8 @@ impl MultiTransportProvider {
             return Err(eyre::eyre!("No RPC URL provided"));
         }
 
-        let url = Url::from_str(rpc_url)?;
-
         let this = if rpc_url.to_lowercase().contains("http") {
+            let url = Url::from_str(rpc_url)?;
             Self::Http(ProviderBuilder::new().on_http(url))
         } else if rpc_url.to_lowercase().contains("ws") {
             let ws = WsConnect::new(rpc_url);

diff --git a/crates/common/src/ether/signatures.rs b/crates/common/src/ether/signatures.rs
@@ -10,7 +10,7 @@ use crate::{
     },
 };
 use eyre::{OptionExt, Result};
-use heimdall_cache::{store_cache, with_cache};
+use heimdall_cache::with_cache;
 use serde::{Deserialize, Serialize};
 use tracing::trace;
 
@@ -267,10 +267,6 @@ impl ResolveSelector for ResolvedFunction {
                 });
             }
 
-            // cache the results
-            let _ = store_cache(&format!("selector.{selector}"), &signature_list, None)
-                .map_err(|e| trace!("error storing signatures in cache: {}", e));
-
             Ok(match signature_list.len() {
                 0 => None,
                 _ => Some(signature_list),