Steps to adding Mac support #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemPopof
changed the title
|
It seems like MacOS and Linux shared libraries implementations are the same except shared library file extensions. |
|
using SharedLibrary = os::LinuxSharedLibrary; //for mac os system. |
|
Maybe it can do the trick now, but in future MacOS version may change, so I thinks you can assign Linux version only if you 100% sure that realization gonna stay the same over the time. |
|
I guess we can change implementation of mac os shared library to it's own specific version when it fork from linux version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.