Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the extension from the filename #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cristianoteles
Copy link

Remove the extension from the filename to route with extension file. Example: Route::get('manifest.json')

Remove the extension from the filename to route with extension file.
Example: Route::get('manifest.json')
Copy link
Owner

@JosephSilber JosephSilber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. How will that work with the webserver, which does add it on?
  2. What's the motivation for this change?
  3. If we do make this change, it needs tests.

@cristianoteles
Copy link
Author

  1. In the same way as any other request, instead of processing in real time it will take from the generated/cached file
  2. Work with whitelabel SaaS solutions, where each domain has a different json file
  3. OK, I can arrange

@JosephSilber
Copy link
Owner

In the same way as any other request, instead of processing in real time it will take from the generated/cached file

How so? The webserver will look for manifest.json.json, which doesn't exist.

Work with whitelabel SaaS solutions, where each domain has a different json file

I don't understand how that pertains to the discussion at hand. How does the stored extension affect that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants