Skip to content

Commit

Permalink
Disable 10bit A/XRGB formats in VOP2
Browse files Browse the repository at this point in the history
rk3588 hw only supports XRGB2101010 with AFBC mode, does not support
ARGB2101010 at all.
Current drm driver falsely advertises support for both with both in
linear and AFBC modes as well. Current state of VOP2 driver has no
mechanism to distinguish support per modifier so it is not also possible
advertise support for XRGB2101010 only with AFBC support without
refactoring the driver. Therefore, this patch disables both XRGB2101010
and ARGB2101010 until rockchip resolves the problem with a sutainable
fix. If not applied, kodi with GBM will display black screen.

Reference from rockchip:
nyanmisaka/ffmpeg-rockchip#4 (comment)
  • Loading branch information
boogieeeee authored and Joshua-Riek committed Apr 30, 2024
1 parent a961aab commit 2ae3e73
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@
_VOP_REG(off, _mask, s, true)

static const uint32_t formats_for_cluster[] = {
DRM_FORMAT_XRGB2101010,
DRM_FORMAT_ARGB2101010,
DRM_FORMAT_XBGR2101010,
DRM_FORMAT_ABGR2101010,
DRM_FORMAT_XRGB8888,
DRM_FORMAT_ARGB8888,
DRM_FORMAT_XBGR8888,
Expand Down

0 comments on commit 2ae3e73

Please sign in to comment.