-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Olympia mappings - runtime forum/proposals changes adjustments, support for forum tags and proposals discussion #2547
Olympia mappings - runtime forum/proposals changes adjustments, support for forum tags and proposals discussion #2547
Conversation
…on utilizing the browsers crpyto api
…neration Update election salt function to use proven crypto implementation
…, remove BTree(Set|Map) workarounds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in the comment above ☝️ Most of the things in the Pioneer app works properly with the Olympia testnet.
This issue is being solved in Hydra PR Joystream/hydra#453 and tracked in ticket Joystream/hydra#444 . So I think we can merge this PR and solve the said problem separately. |
Includes merged and updated work from #2436 (proposals discussion mappings) and adjustments related to changes introduced in:
PostId
is now retriveable fromThreadCreated
event dataPollInput
type was introduced, which fixes the issue related to forum poll input dataThreadTitle
->ThreadMetadata
runtime renaming for consistency due to the introduction ofForumThread
metadata in order tu support forum tags (Olympia: Support for forum thread labels/tags #2422)ProposalId
was incuded as part ofproposalCodex.ProposalCreated
event andproposalEngine.ProposalCreated
event was removed, unifying the source of new proposal data and allowing to remove the temporary workaround with cached proposal id.Notable changes:
create_thread
extrinsic andedit_thread_metadata
(previouslyedit_thread_title
) now take encodedForumMetadata
as argument. TheThreadTitleUpdatedEvent
entity has been renamed toThreadMetadataUpdatedEvent
ForumTag.visibleThreadsCount
andForumThread.visiblePostsCount
fields have been added, which will faciliate querying forum threads / tags by popularity (required by Pioneer 2).visible
means that the posts/threads beeing counted are eitherActive
orLocked
, so this excludes posts/thread that are (or in case of post - are part of a thread that is)Moderated
orRemoved
.ID
create_thread
has been changed to take the actual input data instead of hashes.delete_posts
extrinsic signature has been changed. The extrinsic now takesBTreeMap
as argument, which may require updating to@polkadot/api
5.2.1
(see: BTreeSet and BTreeMap - encoding and serialization fixes polkadot-js/api#3789) (this update was already done on this branch)