Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4487 validator profiles #4539

Merged
merged 20 commits into from
Dec 4, 2023
Merged

Conversation

eshark9312
Copy link
Contributor

@eshark9312 eshark9312 commented Sep 13, 2023

I replaced fake verified validators by the actual QN validator profile

> Story

@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Nov 29, 2023 3:44pm
pioneer-2 ✅ Ready (Inspect) Visit Preview Nov 29, 2023 3:44pm
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Nov 29, 2023 3:44pm

@eshark9312 eshark9312 force-pushed the 4487-validator-profiles branch from b3ae69f to e21366c Compare September 18, 2023 02:46
@eshark9312 eshark9312 force-pushed the 4487-validator-profiles branch from 247b0d3 to e21366c Compare September 18, 2023 05:36
@eshark9312 eshark9312 requested a review from thesan September 18, 2023 09:45
Copy link
Contributor

@chrlschwb chrlschwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not push files in the __generated__ folder

@eshark9312
Copy link
Contributor Author

@chrlschwb

do not push files in the generated folder

I think these files should be updated.

Copy link
Collaborator

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @eshark9312 please stop systematically force pushing your changes, it makes it really difficult to see what changed since the last review. If the reason you are doing it is to rebase on the latest dev, could you try to merge dev into your branch instead please ?

@eshark9312
Copy link
Contributor Author

@thesan

Hey @eshark9312 please stop systematically force pushing your changes, it makes it really difficult to see what changed since the last review. If the reason you are doing it is to rebase on the latest dev, could you try to merge dev into your branch instead please ?

Sorry for that, I got it.

@eshark9312 eshark9312 requested a review from thesan December 1, 2023 14:39
Copy link
Collaborator

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thesan thesan merged commit 192f6f3 into Joystream:dev Dec 4, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-dev issue suitable for community-dev pipeline scope:validators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants