show emails modal after member creation #4579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thesan
requested changes
Oct 16, 2023
There was a problem hiding this comment.
I see the design wasn't fully thought through here but here's what I'm proposing:
- no changes: buy membership form
- no changes: the sign & send transaction modal
- After the transaction succeeded the email registration modal
- After the signup mutation (or the user has clicked "not now") the usual confirmation modal
WDYT ?
kdembler
force-pushed
the
backend-new-member-signup
branch
from
82e73fd to
85728d9
Compare
thesan
approved these changes
Oct 18, 2023
thesan
added
scope:notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds email subscription modal right after new member is created. To achieve this with minimal changes, the existing behaviour of showing subscription modal to active users is used. Whenever new user is created (faucet/buy), members will be refetched and the active member will be set to newly created once the flow is finished. This will trigger the subscription modal.
I've also made some improvements to QN sync logic so that block height can be used to check QN tx inclusion.
Resolves #4235 and #4566