Preview freeze pallet proposal #4627
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrlschwb
added
community-dev
…iew-freeze-pallet-proposal
| onChange: (option: PalletFrozenStatus) => void | ||
| } | ||
|
|
||
| export const OptionsPalletFrozenStatus = React.memo(({ onChange }: Props) => { |
There was a problem hiding this comment.
I think this file is not needed
| selectedStatus?: boolean | ||
| onChange: (selected: PalletFrozenStatus) => void | ||
| } | ||
| export const SelectPalletFrozenStatus = ({ selectedStatus, onChange }: Props) => { |
| export const UpdatePalletFrozenStatus = () => { | ||
| const { watch, setValue } = useFormContext() | ||
|
|
||
| const setPalletFrozenStatus = (selected: PalletFrozenStatus) => { |
| @@ -80,6 +80,10 @@ export type UpdateChannelPayoutsDetail = { | |||
| payloadHash?: string | |||
| payloadDataObjectId?: string | |||
| } | |||
| export type UpdatePalletFrozenStatusDetail = { | |||
| frozen?: boolean | |||
There was a problem hiding this comment.
Here too please change frozen to freeze because it's the action that the proposal should apply (not the current state).
| { | ||
| label: 'Proposed Status', | ||
| renderType: 'Text', | ||
| value: value ? 'Enable' : 'Disable', |
There was a problem hiding this comment.
I think it's the opposite if we want to freeze the pallet the proposed status is "Disable" otherwise "Enabled".
Also please rename value to freezePallet
| renderType: 'Text', | ||
| value: value ? 'Enable' : 'Disable', | ||
| }, | ||
| ] |
There was a problem hiding this comment.
Also the pallet should be displayed too
| value: value ? 'Enable' : 'Disable', | ||
| }, | ||
| ] | ||
| } |
There was a problem hiding this comment.
And I'm wondering if the current pallet state should be displayed too. WDYT @dmtrjsg @chrlschwb ?
There was a problem hiding this comment.
Yes, I think that's good to have.
| @@ -359,6 +369,12 @@ const asUpdateChannelPayouts: DetailsCast<'UpdateChannelPayoutsProposalDetails'> | |||
| payloadDataObjectId: extra?.payloadDataObjectId, | |||
| }) | |||
|
|
|||
| const asUpdatePalletFrozenStatus: DetailsCast<'UpdatePalletFrozenStatusProposalDetails'> = (fragment) => ({ | |||
| type: 'updatePalletFrozenStatus', | |||
| frozen: fragment.frozen, | |||
There was a problem hiding this comment.
| frozen: fragment.frozen, | |
| freeze: fragment.frozen, |
Preview freeze pallet proposal and continuation of this PR #4625
┆Issue is synchronized with this Asana task by Unito