Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address rwd qa test issues #4661

Merged
merged 6 commits into from
Dec 4, 2023

Conversation

eshark9312
Copy link
Contributor

Address the issues from QA test

Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Dec 4, 2023 5:20pm
pioneer-2 ✅ Ready (Inspect) Visit Preview Dec 4, 2023 5:20pm
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Dec 4, 2023 5:20pm

Comment on lines 5 to 6
export const ProposalColLayout = '296px 148px 156px 60px'
export const ProposalColLayoutWithVoteDetails = ProposalColLayout + ' 80px'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't the 60px be removed ? Because this grid always seem to have an unused column.

For normal members:
image

For CMs:
image

Copy link
Collaborator

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-dev issue suitable for community-dev pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants