⬆️ Update to Nara types #4802
Merged
⬆️ Update to Nara types #4802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thesan
force-pushed
the
nara-update-types
branch
from
e3df9cb to
5b79aed
Compare
thesan
force-pushed
the
nara-update-types
branch
2 times, most recently
from
b646f54 to
fbecfb0
Compare
thesan
force-pushed
the
nara-update-types
branch
from
fbecfb0 to
a81d704
Compare
Add GitHub member links
kdembler
reviewed
Mar 18, 2024
kdembler
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hashing function tests were failing due to the testing environment (particularly the custom Buffer implementation from the jest jsdom environment). I managed to fix the voting tests, but the tests from
test/common/utils/crypto.test.tsare more complex to fix so I commented part of the failing tests and skipped one altogether.Also this PR seems to fix the Validator APR issue.